Migrate to use Vite instead of Create React App#515
Open
thienandangthanh wants to merge 25 commits intobalena-os:masterfrom
Open
Migrate to use Vite instead of Create React App#515thienandangthanh wants to merge 25 commits intobalena-os:masterfrom
thienandangthanh wants to merge 25 commits intobalena-os:masterfrom
Conversation
- copy src directory - move public/index.html to index.html - remove %PUBLIC_URL% - add module script to the bottom of the body tag
Reason: to match create-react-app output
Reason: %PUBLIC_URL% is not used with vite
thienandangthanh
force-pushed
the
migration/vite
branch
from
48e1ae1 to
43a5e4f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Reason: to serve with wifi-connect binary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #514
What have been done
huskyandlint-stagedcreate-react-appwithviteReference